[eas-cli] Require --environment flag for eas update when SDK >= 55#3418
Open
douglowder wants to merge 4 commits intomainfrom
Open
[eas-cli] Require --environment flag for eas update when SDK >= 55#3418douglowder wants to merge 4 commits intomainfrom
douglowder wants to merge 4 commits intomainfrom
Conversation
Ensures that server-side environment variables are always explicitly specified for projects using Expo SDK 55 or greater. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Subscribed to pull request
Generated by CodeMention |
|
✅ Thank you for adding the changelog entry! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
==========================================
+ Coverage 52.54% 52.56% +0.02%
==========================================
Files 806 806
Lines 33621 33633 +12
Branches 6986 6988 +2
==========================================
+ Hits 17664 17675 +11
- Misses 14571 14573 +2
+ Partials 1386 1385 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Problems can occur if an update intended for a development build is published with the environment defaulting to or set to production, and vice versa.
To prevent such problems in the future, this PR makes the
--environmentflag a required flag for projects using SDK 55 and greater.How
Add a new utility function to throw an error if sdkVersion does not meet the requirement, and use that function in
eas update:configureandeas update.Skip the check if EAS_BUILD env is set.
Test Plan
Unit tests added.
Testing locally with different projects.